https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|In Discussion |Signed Off --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #3)
I don't feel like the suggested fix is correct. If you don't allow suggestions, but ILL is turned on, now nothing displays. I think as the hints are arranged as list items, there is no reason not to show ILL in this constellation:
- not logged in - ill module enabled - suggestions and anon suggestions not active
But we actually don't show ILL in that situation, the logic to show ILL is: [% IF Koha.Preference( 'ILLModule' ) == 1 && loggedinusername %] So if not logged it it never shows, so the check for logged in username means the removal of the ILL check in the larger loop has no effect. I think this one can move forward -- You are receiving this mail because: You are watching all bug changes.