https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #5)
I've tested and happy to sign off, but Katrin's comments in comment #3 are not all addressed - still 1, 2 and 4 to address
(In reply to Katrin Fischer from comment #3)
1) accountline-details: The h2 heading should be inside the page-section to match the other pages.
I didn't change this at first because for me the h1 wasn't displaying at all. Rather than fixing the template logic that causes this I think the correct solution is to display a generic "Transaction details" h1 since the h2 shows the transaction type.
2) patroncards/manage.tt: same as above.
This page looks correct to me. Am I missing it?
4) Unrelated to the patch, but: New list > h1 should be outside page-section.
This should be a separate issue, but we're running into some situations where we don't yet have a plan. The h1 on that page is inside a <legend>, which by definition is inside the fieldset (styled as page-section). The legend was added to comply with accessibility guidelines. Perhaps the legend should be screen-reader only and the h1 moved outside it. -- You are receiving this mail because: You are watching all bug changes.