https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Lari Taskula from comment #27)
(In reply to Tomás Cohen Arazi from comment #18)
This is also missing some tests for the Recovery.pm changes (url param).
Hi Tomas, and Kyle, nice to see you testing and QA'ing this. I can confirm the missing tests - Recovery.pm::SendPasswordRecoveryEmail() is missing tests for the changes introduced in the second and third patch (url and skip_mail parameters). The main functionality is tested in the REST tests but of course we should still add unit tests to SendPasswordRecoveryEmail itself.
We are almost on feature freeze. If the RM would consider this for inclusion (I would include it, as it is not going to break any existing feature) I can help with the missing tests. -- You are receiving this mail because: You are watching all bug changes.