http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #23)
Just a question from quickly glancing through your code. In CancelExpiredReserves: + my $query = "SELECT * FROM reserves WHERE TO_DAYS( NOW() ) - TO_DAYS( waitingdate ) > maxpickupdate AND found = 'W' AND priority = 0"; Does that work? Looks to me that it doesn't. Shouldn't you just look for maxpickupdate < now?
Yes, of course! (new patch coming) (In reply to comment #24)
(In reply to comment #22)
Questions, does this take into account days the library is closed? It would make sense for the expiration day for pickups to skip to the next open day if they land on a holiday. This is something that needed has needed to be addressed for some time now.
Looks like that this report does not do that. I agree that it should, but you could say that it is beyond scope here? Followup or additional report? But this report does pave the way. We only have to refine the routine where maxpickupdate is calculated now.
Yes, that can be developed later without investing too much effort. (In reply to comment #25)
Hm, there is a downside to the new column too - we loose a bit of flexibility. Say a library closes for some time and changes the pickup delay to be longer, so the holds don't go stale - with the patch in effect they would have to do a database update to those holds. It's only one use case I have come up with so far. There might be other disadvantages/advantages of both ways of doing it.
You are right. But do you think many librarians often change this value? I don't see how to manage the feature and this use case. We can imagine a script that modifies directly the max pickup date in DB according some variables. -- You are receiving this mail because: You are watching all bug changes.