http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9737 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #11)
When you said that you got 1 "no cover image available" in master, I assume that also meant that the local cover didn't appear. I think that's a much more critical issue than having 2 "no cover image available" appear alongside an existing local cover image.
Agreed
Unfortunately, I don't think the code snippet that you provide would actually work, because that would just test for the system preference and not the actual presence of cover images. If you had GoogleJackets and OPACAmazonCoverImages turned on, you would never get a "no cover image available" even when you should.
Yep, of course, stupid code :-/
Maybe if we re-wrote all the cover art functions (and ideally allowed librarians to rank the providers so that you don't have more than cover image showing for an item), but yes...I think that's a different bug.
Could you open a new bug for that please?
If I've managed to convince you, please change back to Signed Off (or even Passed QA :P)
Yes, you are. Thank you for your detailed explanation :) Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.