https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #3)
Another nice bit of cleanup here.
There are a few cases of "$debug and warn..." lines, but they appear to hard code setting `$debug = 0` internally and can be handled in another report I think.
Yes, it is expected. It's from scripts, not module. I thought it would be good to keep them. (In reply to Marcel de Rooy from comment #8)
+#warn "Got ", scalar(@mapkeys), " ldap mapkeys ( total ): ", join ' ', @mapkeys, "\n"; @mapkeys = grep {defined $mapping{$_}->{is}} @mapkeys; -$debug and print STDERR "Got ", scalar(@mapkeys), " ldap mapkeys (populated): ", join ' ', @mapkeys, "\n"; +#warn "Got ", scalar(@mapkeys), " ldap mapkeys (populated): ", join ' ', @mapkeys, "\n";
Any plans here ?
I don't think they should be logged, but they sounded useful, in case someone need to debug LDAP. (In reply to Marcel de Rooy from comment #9)
+ warn #"Finished \%memberhash has ", scalar(keys %memberhash), " keys\n", "Referencing \%mapping with ", scalar(keys %mapping), " keys\n";
Typo typo
Oops, will fix. (In reply to Marcel de Rooy from comment #10)
Just a side note: - if ($pkt =~ /AZ(....)$/) { - $debug and warn "verify_cksum: sum ($1) detected"; - } else { + unless ($pkt =~ /AZ(....)$/) {
I have something with unless. When the ifs go down and the unlesses go up, Koha gets more complicated ;)
I like unless :) (In reply to Marcel de Rooy from comment #11)
-$ENV{DEBUG} = 1; -warning_like { in_iprange("192.168.1.1/36") } - qr/cidrlookup failed for/, - 'noisy simple invalid ip range/36 with remote ip in it';
Why removed?
Heh, it was not trivial to keep as we are now using Koha::Logger, and didn't think very useful to keep anyway. -- You are receiving this mail because: You are watching all bug changes.