http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #26 from M. Tompsett <mtompset@hotmail.com> --- (In reply to David Cook from comment #25)
Hmm, it might be a better idea to add a parameter instead of using the $persona parameter in C4::Auth::checkauth().
I would think the parameter would be better renamed to $AuthenticatedEmail, because persona and this OAuth patch both authenticate against an Email address (the primary email address is used to find the user).
C4::Auth needs a clean-up in general... which Martin (ashimema) is working on, I believe.
True, it does need clean-up.
In any case, locally I added a $external_authen hashref as a parameter after $persona. I use $external_authen->{OpenIDConnect} to store the data I need to pass to checkauth(), add some handling in the appropriate spots, and that's it.
NOOOOOO! Please hashref the parameter! If there are more than 3 parameters, you probably should use a hashref. -- You are receiving this mail because: You are watching all bug changes.