https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #10)
(In reply to Tomás Cohen Arazi from comment #9)
(In reply to Jonathan Druart from comment #5)
I will amend the patch with - ) unless scalar @{$sets} > 0; + ) unless @$sets;
Why? I prefer what I wrote and have been adding it all the time. If it makes more sense to do it your way, we should make sure it is in the guidelines. I still prefer to have the reader understand we are talking about the list size.
ok, reverted.
@$sets does exactly what you are describing, just less verbose. Nevermind.
I like your approach, is more Perl-ish, and we should adopt it as a guideline. -- You are receiving this mail because: You are watching all bug changes.