https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Alex Arnaud from comment #4)
Comment on attachment 72810 [details] [review] Bug 20385 - Don't try to get info for bad authtypecodes
Review of attachment 72810 [details] [review]: -----------------------------------------------------------------
::: Koha/SearchEngine/Elasticsearch/Search.pm @@ +217,4 @@
# with the record. It's not documented why this is the case, so # it's not reproduced here yet. my $authtype = $rs->single; + my $auth_tag_to_report = $authtype ? $authtype->auth_tag_to_report : $authtypecode;
Works fine but i feel not confortable with the fact of putting an auth type code inside a variable supposed to contain a marc field tag. Why not just ''?
Agreed. Failed QA -- You are receiving this mail because: You are watching all bug changes.