https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #77 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Good progress here, just a few more follow-up points: 1) The error handling in confirm_hold has improved with the exceptions but there is an instance where it is called in Checkins.pm (line 258) with no try/catch block to handle these exceptions. The method would 500 error with no message bubbling back to the UI and the holds queue and bundle logic would be skipped 2) I think confirm_hold should maybe be wrapped in a transaction? There are multiple writes and if any exception is thrown in the transfer logic a hold could be stranded in transit with no transfer applied to it 3) onClaimResolved just looks for the first claim row in the table, it doesn't match the claim_id of the claim that was actually resolved - could create mismatches. The id should be passed with the emit and matched 4) CheckinOptions.vue the return-date-override formatting is much better but in the legacy code there was a block on entering dates in the future which we are now missing, as well as the ability to set the time 5) X-Koha-Module-Policy header is only defined in 2** response schemas but appears to be used on 403 responses where it isn't defined 6) The Location header for the /checkins/* endpoints doesn't resolve - it would return Location: /api/v1/checkins/1/hold_confirmation/1 which is appending an unnecessary id param to the end of the URL -- You are receiving this mail because: You are watching all bug changes.