https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #21)
(In reply to Marcel de Rooy from comment #20)
Martin: Are you happy with the way this patch deals with the cancellation as to the accounts handling? Testing amountoutstanding and choosing line->cancel or account->add_credit? Balance wise, it works fine.
I think ->cancel is correct but cancelling has some caveats: some exceptions will be thrown if (say) the line is already offsetted (partially/fully payed, writen off, etc).
Those cases lead me to think ->void would suit better, but we need to (maybe) think about possible refunds.
Agustin compares amount with outstanding before calling cancel. So that should be fine, I guess. It fixes the earlier problem reported. -- You are receiving this mail because: You are watching all bug changes.