https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks good to me overall (see also comment47). No blockers found. Koha::Patron::Message::Preferences sub find_with_message_name my $attr = Koha::Patron::Message::Attributes->find({ message_name => $id->{'message_name'}, }); Isnt this actually a search? Couldnt we have multiple results on name ? Similar question for search_with_message_name later my $name = $transport->get_column('message_name'); Why get_column, not just message_name ? +=head3 search + +Koha::Patron::Message::Preferences->search_with_message_name({ + borrowernumber => 123, + message_name => 'Hold_Filled', +}); Wrong POD header -- You are receiving this mail because: You are watching all bug changes.