https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #181 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #179)
QA Comment: I re-entered the example with 8 * 16,99 and 42% discount, 19.45% tax.
With the following results when patches applied: OrderPriceRounding=Dont Basket page 78,83 + 15,33 tax. == 94,16 Fund page 94,17 => No match between basket and fund !
OrderPriceRounding=Nearest cent Basket page: 78,80 + 15,33 tax == 94,13 Fund page: 94,16 => No match either between basket and fund !
And without these patches: Basket page 78,83 + 15,33 tax. == 94,16 Fund page: 94,17 => No match either.
Conclusion: Please see also my previous comments. I am not repeating them here. With the default setting of Don't round we make no difference in this example; so no behavior change.. The Nearest cent choice does not resolve the discrepancy between basket and fund, as noted before.
As already mentioned, I do not object to push this patch set. But this simple exercise already shows that we did not solve the rounding issues.
Passed QA
You are right :-) I talked to others though and general consensus was this is a big change and should tackle issues raised on follow-ups. I think this does some good things and paves the way for more work forward so pushed. Thanks Marcel -- You are receiving this mail because: You are watching all bug changes.