https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #31 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #30)
David, just glancing over but this code looks very good.
Thanks, Marcel :)
Just thinking that Koha::Auth may be quite ambitiously named for now. How long will we have C4::Auth and Koha::Auth side by side?
Probably for a while, but Koha::Auth can be a target for any new auth work or for refactoring work. In Bug 31389, I've created Koha::Auth::Permissions, which contains a function to be used in C4::Auth. I suppose we could always use Koha::Mojo::Auth or some other Koha::Auth::* module instead of Koha::Auth.
Do we actually need the 'staff' script or was it jusy easy while testing?
The "staff" script is for non-Plack enabled Koha instances. "api/v1/app.pl" works similarly. Although, in plack.psgi, the API gets loaded by loading that file whereas I just load the Koha::Mojo::Staff module as I think that's cleaner. -- You are receiving this mail because: You are watching all bug changes.