https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #115 from Brendan Lawlor <blawlor@clamsnet.org> --- This patch removed/changed these lines in opac-reserve.pl: - my $status = CanBookBeReserved( $borrowernumber, $biblioNum )->{status}; - $biblioLoopIter{holdable} &&= $status eq 'OK'; - $biblioLoopIter{$status} = 1; Without $biblioLoopIter{$status} = 1; the statuses returned by CanBookBeReserved are never set as keys in $biblioLooperIter, so in the template the error messages can never be shown. E.g. in opac-reserves.tt:221-247 [% ELSIF bibitemloo.itemAlreadyOnHold %] <div class="alert alert-warning">This title cannot be requested because you already have hold for this item.</div> Also I think the new recordHoldsOnly and recordHoldNotAllowed should have messages added to opac-user.tt:79-115 -- You are receiving this mail because: You are watching all bug changes.