https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112283|0 |1 is obsolete| | --- Comment #63 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 112290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112290&action=edit Bug 23971: (follow-up) Fix tests Following a discussion with Tomás on Slack, this commit implements the following suggestions: - Switch from ->find to ->search in tests. ->find is only ever going to return 0 or 1 rows, which doesn't help us if there is breakage which results in more than 1 row being returned, the test would fail due to ->find not expecting more than 1 row, but we should be testing for it. So switching to ->search returns all matching rows. - Moved tests into their own subtest, they had the potential to pollute surrounding tests - Remove all action logs before each test, this ensures we're only testing the result of the current test -- You are receiving this mail because: You are watching all bug changes.