https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34353 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198229&action=edit Bug 34353: (QA follow-up) Migrate spinelabel for both holdings tables The catalogue_detail.inc include is shared by both the holdings_table and otherholdings_table tabs, so the column visibility migration must seed both. Without this, sites that previously had 'SpineLabelShowPrintOnBibDetails' set to "Don't show" would still see the spine-label column appear in the other-holdings tab. Also mark 'spinelabel' as is_hidden by default in admin/columns_settings.yml for both tables, so fresh installs (where the atomicupdate doesn't run) match the previous syspref default of 0 (Don't show). Test plan: 1. Reset the database, do not apply the parent patch yet. 2. With the syspref still present, set it to "Don't show" and save. 3. Apply the parent patch and this follow-up, then update the database. 4. Navigate to a record with items in both 'Holdings' and 'Other holdings' tabs. 5. Verify the 'Spine label' column is hidden in BOTH tabs. 6. Reset the database again. Set the syspref to "Show", save, then apply patches and update the database. 7. Verify the 'Spine label' column is visible in BOTH tabs. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.