https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25965 --- Comment #12 from Lari Strand <lmstrand@gmail.com> --- (In reply to David Cook from comment #10)
I notice a few hard-coded references to koha-suomi.fi, so those would need to be removed and use replaceable placeholders.
That's true, the contents inside the xml elements are being validated and need to match the xml schema exactly. I'll work on that.
You'll want to take a look at the coding guidelines too (https://wiki.koha-community.org/wiki/Coding_Guidelines), as I think you've used tabs here instead of 4 spaces (per tab).
I used Eclipse's formatting tool to format the code. I wasn't aware you can't use tabs. I'll remove the tabs in an updated version.
For the config, you might want to put it into koha-conf.xml as well (even if I do think that we overload that 1 configuration file with everything...)
Other than that, can you give us a test plan for how to get this to work?
I'll write a short description on how to set this up.
Ideally, it would be great if it could work in koha-testing-docker (https://gitlab.com/koha-community/koha-testing-docker).
Overall, it's looking good. Thanks for posting it!
I'll check on the koha-testing-docker stuff, can't make any promises :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.