https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was about to pass this, but then found 2 things: 1) The text will only be true if OpacSuppression is turned on. So I think we will want to add a check for that, maybe here? unless ( $marcflavour eq 'UNIMARC' ) { 2) With all the discussion recently - I am a bit worried about performance here. Could it be speedier to send the original value of 942$n (the code) to the template and check for 1/something vs. 0/empty? This way we wouldn't have to care about the AV or framework. But not sure if this is an option. I included a typo fix in the last patch, as the QA tools had complained about it. It's in one of the comments. -- You are receiving this mail because: You are watching all bug changes.