https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #37 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #36)
(In reply to Jonathan Druart from comment #34)
Personally, I think it's risky making so many changes all at once, especially when there are different types of changes made here. Some are fixing BEGIN blocks in .pm modules while others are fixing that non-existent import issue.
They are not that big and an attentive code review can help to catch issues. They are all doing fixing import/export issues. IMO it makes sense to push them all at the same time.
(In reply to Jonathan Druart from comment #35)
If you prefer to move forward with the existing patches feel free to change the status. We can actually move forward, but we cannot make sure we won't introduce regressions in the meantime (people won't look at the Jenkins job if it's failing for another known reason).
Can you clarify what you mean here?
It sounds to me like you're saying we should push the many changes, but that it would mean we might introduce regressions? Or am I misunderstanding?
Or do you mean separate from this work that we might add regressions in unrelated patches, because we haven't moved to the newer OSes yet?
By "regressions" I meant "new problematic occurrences". The original goal here is to fix xt/pl_valid.t on D13. Without all the perl files fixed, the job will still fail. And nobody will care if new occurrences are pushed. But forget that. I agree with you: we don't need to wait and we should push what has been fixed already. -- You are receiving this mail because: You are watching all bug changes.