https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42311 --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- @davidnind, it would be great if you shared your failures info. I just did the following and all tests succeeded: 1) Launch a clean 'main' KTD because 'misc4dev' fails to inject holidays on the new schema ```shell git checkout origin/main -b qa_42311 ktd --proxy --name qa42311 up -d ktd --name qa42311 --wait-ready 200 ``` 2) Apply the patches (replied 'y' to all questions): ```shell ~/git/koha qa_42311:main *27 ?2 01:57:01 p. m. ❯ git bz apply 42311 📋 Bug 42311 depends on bug 42314 (Signed Off) Follow? [(y)es, (n)o] y 📋 Bug 42314 depends on bug 42310 (Signed Off) Follow? [(y)es, (n)o] y 📋 Bug 42310 depends on bug 42206 (Signed Off) Follow? [(y)es, (n)o] y 📋 Bug 42206 - Add REST endpoint GET /libraries/{library_id}/closed_dates • 196969 - Bug 42206: Add GET /libraries/{id}/holidays endpoint • 196970 - Bug 42206: (follow-up) Rename to /closed_dates, improve efficiency Apply? [(y)es, (n)o, (i)nteractive] y Preparing 2 patch(es): ✓ Prepared 2 patch(es) Applying 2 patch(es): ✓ [1/2] Applied Bug 42206: Add GET /libraries/{id}/holidays endpoint ✓ [2/2] Applied Bug 42206: (follow-up) Rename to /closed_dates, improve eff… ✓ Successfully applied 2 patch(es) from bug 42206 ⠧ Fetching bug 42310 attachments...^R 📋 Bug 42310 - Move calendar CRUD to Koha::Calendar::* with normalized schema • 197030 - Bug 42310: Normalize calendar tables • 197031 - Bug 42310: Add Koha::Calendar::* Object classes • 197032 - Bug 42310: Refactor Koha::Calendar to use Koha::Calendar::* classes • 197033 - Bug 42310: (follow-up) Add missing POD • 197034 - Bug 42310: (follow-up) Remove DBIC schema files for dropped tables • 197035 - Bug 42310: (follow-up) Adapt Calendar tests to new schema • 197036 - Bug 42310: (follow-up) Add CRUD methods to Koha::Calendar, delegate C4::Calendar • 197037 - Bug 42310: (follow-up) Bake cache invalidation into Koha::Object classes Apply? [(y)es, (n)o, (i)nteractive] y Preparing 8 patch(es): ✓ Prepared 8 patch(es) Applying 8 patch(es): ✓ [1/8] Applied Bug 42310: Normalize calendar tables ✓ [2/8] Applied Bug 42310: Add Koha::Calendar::* Object classes ✓ [3/8] Applied Bug 42310: Refactor Koha::Calendar to use Koha::Calendar::*… ✓ [4/8] Applied Bug 42310: (follow-up) Add missing POD ✓ [5/8] Applied Bug 42310: (follow-up) Remove DBIC schema files for dropped… ✓ [6/8] Applied Bug 42310: (follow-up) Adapt Calendar tests to new schema ✓ [7/8] Applied Bug 42310: (follow-up) Add CRUD methods to Koha::Calendar, … ✓ [8/8] Applied Bug 42310: (follow-up) Bake cache invalidation into Koha::O… ✓ Successfully applied 8 patch(es) from bug 42310 📋 Bug 42314 - Add `Koha::Library->calendar` • 196976 - Bug 42314: Add Koha::Library->calendar accessor • 196977 - Bug 42314: (follow-up) Use Koha::Library->calendar accessor Apply? [(y)es, (n)o, (i)nteractive] y Preparing 2 patch(es): ✓ Prepared 2 patch(es) Applying 2 patch(es): ✓ [1/2] Applied Bug 42314: Add Koha::Library->calendar accessor ✓ [2/2] Applied Bug 42314: (follow-up) Use Koha::Library->calendar accessor ✓ Successfully applied 2 patch(es) from bug 42314 📋 Bug 42311 - REST API CRUD endpoints for library calendar • 197028 - Bug 42311: Unit tests • 197029 - Bug 42311: REST API CRUD endpoints for library calendar Apply? [(y)es, (n)o, (i)nteractive] y Preparing 2 patch(es): ✓ Prepared 2 patch(es) Applying 2 patch(es): ✓ [1/2] Applied Bug 42311: Unit tests ✓ [2/2] Applied Bug 42311: REST API CRUD endpoints for library calendar ✓ Successfully applied 2 patch(es) from bug 42311 ~/git/koha qa_42311:main ⇡14 *27 ?2 40s 01:57:46 p. m. ❯ git checkout qa_42311 Switched to branch 'qa_42311' Your branch is ahead of 'origin/main' by 14 commits. (use "git push" to publish your local commits) ~/git/koha qa_42311:main ⇡14 *27 ?2 02:00:30 p. m. ``` 3) Then update within KTD: ```shell ktd --name qa42311 --shell updatedatabase yarn api:bundle ``` 4) Run the `qa` script which will run the tests: ```shell $ qa Tag v25.05.00-1 found in /kohadevbox/koha — checking out branch main in /kohadevbox/qa-test-tools Already on 'main' Your branch is up to date with 'origin/main'. testing 2 commit(s) (applied to 0f8d960 'e5 Bug 42314: (follow-up) Use Koha::L') Processing files [RUNNING] Koha/REST/V1/Libraries/Calendar.pm [RUNNING] Koha/REST/V1/Libraries/Calendar/ClosureExceptions.pm [RUNNING] Koha/REST/V1/Libraries/Calendar/RepeatingClosures.pm [RUNNING] Koha/REST/V1/Libraries/Calendar/SingleClosures.pm [RUNNING] Koha/REST/V1/Libraries/Calendar/WeeklyClosures.pm [RUNNING] api/v1/swagger/paths/libraries_calendar.yaml [PASS] api/v1/swagger/paths/libraries_calendar.yaml [RUNNING] api/v1/swagger/paths/libraries_calendar_closure_exceptions.yaml [PASS] api/v1/swagger/paths/libraries_calendar_closure_exceptions.yaml [RUNNING] api/v1/swagger/paths/libraries_calendar_repeating_closures.yaml [PASS] api/v1/swagger/paths/libraries_calendar_repeating_closures.yaml [RUNNING] api/v1/swagger/paths/libraries_calendar_single_closures.yaml [PASS] api/v1/swagger/paths/libraries_calendar_single_closures.yaml [RUNNING] api/v1/swagger/paths/libraries_calendar_weekly_closures.yaml [PASS] api/v1/swagger/paths/libraries_calendar_weekly_closures.yaml [RUNNING] api/v1/swagger/swagger.yaml [PASS] api/v1/swagger/swagger.yaml [PASS] Koha/REST/V1/Libraries/Calendar.pm [PASS] Koha/REST/V1/Libraries/Calendar/WeeklyClosures.pm [PASS] Koha/REST/V1/Libraries/Calendar/RepeatingClosures.pm [PASS] Koha/REST/V1/Libraries/Calendar/ClosureExceptions.pm [PASS] Koha/REST/V1/Libraries/Calendar/SingleClosures.pm [RUNNING] t/db_dependent/api/v1/libraries_calendar.t [PASS] t/db_dependent/api/v1/libraries_calendar.t Result: [PASS] Koha/REST/V1/Libraries/Calendar.pm [PASS] Koha/REST/V1/Libraries/Calendar/ClosureExceptions.pm [PASS] Koha/REST/V1/Libraries/Calendar/RepeatingClosures.pm [PASS] Koha/REST/V1/Libraries/Calendar/SingleClosures.pm [PASS] Koha/REST/V1/Libraries/Calendar/WeeklyClosures.pm [PASS] api/v1/swagger/paths/libraries_calendar.yaml [PASS] api/v1/swagger/paths/libraries_calendar_closure_exceptions.yaml [PASS] api/v1/swagger/paths/libraries_calendar_repeating_closures.yaml [PASS] api/v1/swagger/paths/libraries_calendar_single_closures.yaml [PASS] api/v1/swagger/paths/libraries_calendar_weekly_closures.yaml [PASS] api/v1/swagger/swagger.yaml [PASS] t/db_dependent/api/v1/libraries_calendar.t Processing additional checks PASS! * Was this bug sponsored by anyone? Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/api/v1/libraries_calendar.t PASS ``` Tests pass when run manually, and also when running `qa c 14` (i.e. the whole patch series): ```shell ... [PASS] t/db_dependent/Koha/Library.t [PASS] t/db_dependent/Reserves/CancelExpiredReserves.t [PASS] t/db_dependent/api/v1/libraries.t [PASS] t/db_dependent/api/v1/libraries_calendar.t Processing additional checks PASS! Running tests (10) * Proving /kohadevbox/koha/t/db_dependent/Calendar.t PASS * Proving /kohadevbox/koha/t/db_dependent/Circulation.t PASS * Proving /kohadevbox/koha/t/db_dependent/Circulation/maxsuspensiondays.t PASS * Proving /kohadevbox/koha/t/db_dependent/Holds/WaitingReserves.t PASS * Proving /kohadevbox/koha/t/db_dependent/Koha/Calendar.t PASS * Proving /kohadevbox/koha/t/db_dependent/Koha/CurbsidePickups.t PASS * Proving /kohadevbox/koha/t/db_dependent/Koha/Library.t PASS * Proving /kohadevbox/koha/t/db_dependent/Reserves/CancelExpiredReserves.t PASS * Proving /kohadevbox/koha/t/db_dependent/api/v1/libraries.t PASS * Proving /kohadevbox/koha/t/db_dependent/api/v1/libraries_calendar.t PASS ``` -- You are receiving this mail because: You are watching all bug changes.