https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20638 --- Comment #13 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Paul Derscheid from comment #11)
Hi Tomás, this is awesome!
qa script complains, though
They all seem wrong checks. * Exceptions file contains POD, this check always fails. I think it is because our POD describes the various exceptions, which are defined inside the `use` statement. And there are no methods defined so... we might need to fix the QA tools or just not care about this particular error. * The semi-colon one I don't understand it. It is probably another QA script bug. * The HEA one I don't really understand it. I mentioned on the bug that it needs to be revisited. Probably as a warning and with different wording. (In reply to Lisette Scheer from comment #12)
Additionally new logs need to use the diff https://wiki.koha-community.org/wiki/Coding_Guidelines#ACTN1: _New_additions_to_actions_logs_should_use_the_JSON_Diff_format
Thanks for this one. I really didn't know about it. -- You are receiving this mail because: You are watching all bug changes.