https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot@biblibre.co | |m --- Comment #16 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Katrin Fischer from comment #13)
1) QA test tools:
FAIL installer/data/mysql/atomicupdate/update-BZ_10762.pl FAIL file permissions File must have the exec flag
2) See comment#11, it looks like the original value was 0.01:
+ scale_height => 0.02,
- my $barcode_y_scale_factor = 0.01 * $self->{'height'}; # this scales the barcode height to 10% of the label height
3) Defaults
Just a question, maybe someone else can answer that one too:
The patch adds the 2 new database columns with defaults 0.02 and 0.8 in the database and also sets the defaults in new.
Should we do both or would one option suffice?
4) Changes to kohastructure.sql are missing
Hello Katrin, Normally I fixed this things on my last 'push' For default value (repeat in sql and view on 'sub new()' I'm not an expert but it like the same than 'layout_name' for example (set to 'DEFAULT' in default sql value and also in the template when we passed vars). I hope this will be okay for everyone :) -- You are receiving this mail because: You are watching all bug changes.