https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43946 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- I've signed off, but some examples for the second patch would make it much easier to test (for example, an example record and some before and after HTML that shows what is changed when you use Inspect or the Web Developer Tools). Testing notes (using KTD): 1. Set the OPACPopupAuthorsSearch system preference to "Show": - Notes: . If there is only one subject term then there is no pop-up window . If there is only one author (for example, just one "By" author and no "Contributor(s)") . If you click on the magnifying glass/search icon next to the author or term, then there is no pop-up window - you are doing a direct search 2. Install a translation: koha-translate --install fr-FR --dev kohadev 3. Restart everything: restart_all 4. Set these system preferences: - OPACLanguages: select the language you installed - opaclanguagesdisplay: set to "Allow" - StaffInterfaceLanguages: select the language you installed 5. An example record to look at in the OPAC to reproduce the problem: - Programming the Perl DBI (13) - If you inspect the HTML, for example: right click on Perl (Computer program language) - <a class="Sujet".... - After the patch, the correct class name is used: <a class="subject"... 6. After applying the patches, to update the translations: - gulp po:update --lang fr-FR - koha-translate --update fr-FR --dev kohadev - Restart everything: restart_all 7. To get back into a clean state: - cd misc/translator/po - git clean -fd - git reset --hard origin/main - git status - cd /kohadevbox/koha - git checkout main - git branch -D [yourbranchname] - git reset --hard origin/main - git clean -fd - reset_all -- You are receiving this mail because: You are watching all bug changes.