http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13075 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Comment on attachment 32282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32282 Bug 13075 - Silence warnings and improve Charset testing. Review of attachment 32282: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13075&attachment=32282) ----------------------------------------------------------------- ::: C4/Charset.pm @@ +178,4 @@
sub NormalizeString{ my ($string,$nfd,$transform)=@_; + return $string if !defined($string);
could we write this better as return unless $string; Or should we be actually croaking if we call this without actually passing it anything to normalize, instead of silently hiding that we are calling it wrong? -- You are receiving this mail because: You are watching all bug changes.