https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28664 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The patch itself is simple and does the job. But I think we are a bit fragile here. Too much calculation in the controller/templates. Can we add something like: Koha::Account::Line->can_be_reduced Koha::Account::Line->refund and reuse it both in the templates and controllers? I would like the code to explode if tricked to try refunding a 'VOID' line. I can help coding or writing the tests if required. If this is being worked on somewhere else, please point me to the right direction. -- You are receiving this mail because: You are watching all bug changes.