http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #106 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #104)
This sql "parsing" is in the routine C4::Update::Database::get_queries (~20 lines). It's not darkness : If the line begin with '--' it's a comment. If we want to change the delimiter, we change the input record separator. Indeed, by default it's the semicolon character. We want to use this sql statement to know when the query is terminated. Else it's a query
Perhaps we are not understanding what is meant by "parsing" in this context. Does parsing (as used here) simply mean differentiating between a SQL comment and a SQL query? If so, we may be ok.
The routine check_coherency seems to cause problems. In fact, we can bypass this check. But if we want, in the future, translate the errors we have to encapsulate errors for a better usability. Else we would be displaying an error from the DBMS (then not translatable).
I agree with Katrin here. We should pass the error directly as received from the DBMS to avoid linguistical confusion. -- You are receiving this mail because: You are watching all bug changes.