https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40294 --- Comment #70 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 207106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207106&action=edit Bug 40294: (QA follow-up) Fix failing test patrons_self_renewal.t This fixes the failing test patrons_self_renewal.t when a patron is doing a self renewal via API. The called module SelfRenawal creates a letter with - letter_code = "MEMBERSHIP_RENEWED" - is_notice_mandatory = $is_notice_mandatory, - forceprint => 1 The param forceprint will always create a MEMBERSHIP_RENEWED letter with transport 'print'. The param is_notice_mandatory is dependent on the patron category and may randomly evaluate to 1. This would cause a created MEMBERSHIP_RENEWED letter with a transport defined via a fallback chain which is introduced earlier by this bug. As the test expected only the 'print' letter it randomly failed when a letter with a different transport was queued. The test now checks only for the print letter. This also fixes another issue that when forceprint = 1 and the mandatory message fallback was 'print' only one print letter is generated. To test: prove t/db_dependent/api/v1/patrons_self_renewal.t -- You are receiving this mail because: You are watching all bug changes.