https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alex, can you please make a couple fixes? 1) QA test tools FAIL installer/data/mysql/atomicupdate/bug_23352-add_ccode_column_to_subscriptions_table.pl FAIL file permissions File must have the exec flag FAIL valid Useless use of anonymous hash ({}) in void context 2) Handling of default on existing items I am in doubt about these lines: + if ( $itemrecord and $defaultvalues and not $itemrecord->subfield($tag,$subfield->{subfield}) ) { + # if the item record exists, only use default value if the item has no ccode + $defaultvalue = $defaultvalues->{ccode}; I believe that would affect what happens if an item is edited from the serials module? If the item has been created without a collection, we should not 'force' it later. The rule is that if it was emptied out intentionally it should remain empty. 3) Terminology <label for="ccode">Collection code:</label> [% IF ( ccode ) %]<li><span class="label">Collection code:</span> [% ccode | html %]</li>[% END %] As we always display the descriptions and not the codes, we have updated the GUI to always say "Collection". -- You are receiving this mail because: You are watching all bug changes.