https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can see that a lot of work and thought went into this already. Trying to have a look: 1) QA test tools fail [FAIL] Koha/SearchEngine/Elasticsearch.pm FAIL critic Don't modify $_ in list functions at line 837, column 52. See page 114 of PBP. (Severity: 5) FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/SearchEngine/Elasticsearch.pm` [FAIL] t/db_dependent/Koha/SearchEngine/Elasticsearch.t FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/Koha/SearchEngine/Elasticsearch.t` I could fix the tidineyy, but will need you to have a look at the critic failure. Otherwise nothing spotted in the code. Holding off testing until the QA fail is verified/fixed. -- You are receiving this mail because: You are watching all bug changes.