https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43953 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I could not reproduce the failing tests before applying the patch (step 1 of the test plan) - doesn't matter what AllowHoldDateInFuture is set to. The tests pass for me both before and after the patches. Testing notes (using KTD): 1. The default for AllowHoldDateInFuture in KTD is "Don't allow". 2. After applying the patch, not sure if I needed to rebuild everything but did anyway: yarn build and a restart_all 3. Optional step 4: - I gave Henry Acevedo catalogue and place_holds permissions - Using this SQL I got the hold ID: . Access the database: koha-mysql kohadev . SQL: select * from reserves; - Before the patch, using Bruno to make the request, I got a 403 forbidden error unless I give all the "Place and modify holds for patrons (reserveforothers)" permissions. - Before the patch, if I give Henry borrowers permissions, then I can change the hold date with AllowHoldDateInFuture set to both "Don't allow" and "Allow" - After the patch, with Henry having borrowers permissions, things now work as expected: . With AllowHoldDateInFuture set to "Don't allow" - 400 Bad Request error: { "error": "Hold date in future not allowed" } . With AllowHoldDateInFuture set to "Allow", the request succeeds (200 OK). -- You are receiving this mail because: You are watching all bug changes.