https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Martin Renvoize from comment #27)
Is there actually any more discussion to take place here.. it looks like we reached a conclusion that the code all made "sense" given the history of the feature.
The only remaining thing is the following and your message might implicitly mean "out of scope" for that point. At least that didn't strike you as an immediate worthwhile issue ^^
After more testing of the current patches: - Item details page of a record doesn't show "Current renewals:" if there are only legacy renewals.
The current patches introduce an inconsistency with the same feature elsewhere in Koha which has still the old behavior. By default I think that's in scope but there are a lot of case by case exceptions. What do you think? I don't have a strong opinion on it.
And it didn't seem to have caught the eye of Katrin and Pedro either since the 18th. So it safely enough feels like this can move on. Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.