http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Comments from testing (some preliminary QA comments for another QAer): Tested /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=999 with two holds on one item. This attracted my attention: - $biblioitem->{'reserves'}->{'reserve'} = $reserves[1]; + $biblioitem->{'reserves'}->{'reserve'} = $reserves; But it is okay: $reserves[1] was previously the arrayref. So this is a code readability improvement too :) With and without patch I see my two holds in the output. Tested Holds.t and Reserves.t. Pass. Placed biblio holds, future holds and item holds. Works as expected (small note below on opac-detail). C4/SIP/ILS/Item.pm: Looked for "whatever" and "arrayref" and could not find them anymore. OK Template params holds and holdcount are not used in the ISBD template; removed them from catalogue/ISBDdetail.pl in QA followup Same for MARCdetail.pl, imageviewer.pl, labeledMARCdetail.pl and moredetail.pl. Removed use Reserves from moredetail (no longer 'in use'.) In catalogue detail.tt only the number of holds is used. Removed the code that passed the holds array to the template. Tested various settings of OPACShowHoldQueueDetails and corresponding display in opac-detail. For consistency I added the all_dates parameter to the call in opac-detail to incorporate future holds in its count. I just note that the display of count and priority could be improved here but I am already at the scope borders of this report :) [The meaning of something like Total holds: 3 (priority 2) under the items list is rather obscure..] serials/routing-preview.pl: I have the strong feeling that this call of GetReservesFromBiblionumber also needs the all_dates parameter. I have not tested this call (there is no test plan for it too :), so I did not want to touch it now. If you could still have a look, Jonathan, perhaps you could still add that one in a follow-up? No complaints from koha-qa.pl. -- You are receiving this mail because: You are watching all bug changes.