https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #40 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #38)
I think we need some more tests here, particularly for the 'staff_authorize' and 'prepare_template', unless I'm missing something. I noticed at first glance a subtle issue with __koha__user__ vs. __koha_user__ that is not caught by the provided tests.
Good catch with __koha__user__. I hadn't used that return value anywhere yet. Following my unit tests on Bug 30962 and looking at t/Koha/REST/Plugin/Query.t, I think I now know how to write the tests you're talking about. I'll give it a go.
It would be great (also) if you could perltidy some of this code. I usually select the code I want to tidy, and just ctrl+k ctrl+f on VScode. Please do it inline. Thanks!
I think there's a problem with the perltidy vim macro in KTD but otherwise I'm open to it... -- You are receiving this mail because: You are watching all bug changes.