https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #17)
(In reply to Martin Renvoize from comment #15)
Why do you warn $_ ?
Following prior art. It makes sense to warn like this for such errors. I have however added a Koha::Logger based log line too now so we don't lose warnings for cases where cron sends them to dev/null.
You probably mean something else? Like $@ ? The wonderous names of Perl special variables. I am really not sure what $_ would be referring to in this catch block?
eval sets $@, Try::Tiny preserves it just in case you need it for other purposes, and sets $_. So, yes: it is the correct way with Try::Tiny. Look at all the API controllers for examples. -- You are receiving this mail because: You are watching all bug changes.