https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39618 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Oops I thought this was already signed off. I guess I meant sign off rather than QA. This is looking good at a glance. I do notice that it doesn't follow the pattern of most of the other indexes (ie it's missing the "_idx" suffix at the end of the index name), but that's fine I think. Not a real issue. My test plan: 0. Apply the patch 1. sudo koha-mysql kohadev 2. show indexes from borrowers 3. sudo koha-upgrade-schema kohadev NOTE successful database update 4. sudo koha-mysql kohadev 5. show indexes from borrowers NOTE indexes added to table 6. sudo koha-upgrade-schema kohadev NOTE It says it's added the index again (but it hasn't - phew) 7. sudo koha-mysql kohadev 8. show indexes from borrowers NOTE indexes hasn't been added a second time Sorry to say this but I think I am going to mark "Failed QA" again, as I think that "say_success" in the atomic update shouldn't be shown if the database update hasn't been applied. -- You are receiving this mail because: You are watching all bug changes.