https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43729 --- Comment #26 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207338&action=edit Bug 43729: Stop writing the message broker config in koha-create koha-create wrote a <message_broker> block (host/port/user/pass/vhost) into koha-conf.xml and exposed --mb-host/--mb-port/--mb-user/--mb-pass/ --mb-vhost options to configure it. This was only read by the STOMP code path, which has been removed, so it is dropped. Changes: - debian/scripts/koha-create: remove the --mb-* options, their defaults, the set_message_broker() helper, the call, and the __MESSAGE_BROKER_*__ substitutions. - debian/templates/koha-conf-site.xml.in: drop the <message_broker> block. - etc/koha-conf.xml and t/data/koha-conf.xml: drop the <message_broker> block. - t/Koha/Config.t: drop message_broker from the expected parsed config. - debian/docs/koha-create.xml: remove the --mb-* documentation. Existing instances can keep their <message_broker> block; it is simply ignored. The accompanying atomic update points this out. Test plan: 1. Apply patch 2. Run: $ bash -n debian/scripts/koha-create => SUCCESS: syntax OK! 3. Run: $ ktd --shell k$ prove t/Koha/Config.t => SUCCESS: Tests pass! 4. Create a new instance with koha-create and confirm koha-conf.xml has no <message_broker> block and the instance works. => SUCCESS: Instance created, no message broker config! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.