https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139966|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 140505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140505&action=edit Bug 28167: Remove uninitialized variable warnings from circ/set-library.pl With UseCashRegisters syspref disabled going to the page /cgi-bin/koha/circ/set-library.pl in staff interface and setting a library gives the following errors in plack-intranet-error.log: Use of uninitialized value $register_id in string ne at /kohadevbox/koha/circ/set-library.pl line 79. Use of uninitialized value $referer in pattern match (m//) at /kohadevbox/koha/circ/set-library.pl line 114. In the if clause $userenv_register_id appears to be typoed, it should have been $register_id as $userenv_register_id is always defined. As for the $referer variable, it is undef if there is no referer so let's just initialize it to an empty string for the regex so it doesn't give the warning. To test: 1) Go directly to /cgi-bin/koha/circ/set-library.pl by typing it in the URL bar and set a library 2) Make sure plack-intranet-error.log doesn't contain the above mentioned errors after applying this patch Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.