https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's not pushed to master yet, still in NQA. (In reply to Jonathan Druart from comment #7)
Hi Kyle, This patch does a bit more than advertise :) 1/ __MESSAGE_ID__ could be used everywhere, not only for phone notice. I think this should be covered by tests and documented somewhere (eventually added to the notice editor)
Still valid.
2/ + if ( $use_tt ) { + $letter->{content} =~ s/__MESSAGE_ID__/$message_id/g; + print $OUT $letter->{content}; + }
Don't you think it would be better to retrieve the notice instead of duplicating the substitution? It would be less error prone. Btw, why does the script output something different if tt syntax is used?
Still need an answer. Does the --tt flag really makes sense? (In reply to Jonathan Druart from comment #27)
It would also be good to get an independent QA point of view.
Still needed. I will do it myself if no one else does. -- You are receiving this mail because: You are watching all bug changes.