https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Moderate OPAC self |Moderate OPAC |registrations before a |self-registrations before a |patron account is created |patron account is activated Text to go in the|Allow libraries to verify |This enhancement allows release notes|OPAC self registrations |libraries to choose how to |before a patron account is |moderate OPAC |created. |self-registrations before a | |patron's account is |This new feature replaces |activated. |the | |PatronSelfRegistrationVerif |It updates the |yByEmail syspref with two |PatronSelfRegistrationVerif |new sysprefs |yByEmail system preference |PatronSelfRegistrationVerif |with verification options: |yByEmailToLibrary and |* No verification required |PatronSelfRegistrationVerif |* Patron verification |yByEmailToPatron so now |required |libraries can choose one of |* Library verification |the following verification |required |workflows: | | |It also adds a new notice |* Library & patron |that is sent to library |verification |staff if library |* Library verification only |verification is selected: |* Patron verification only |OPAC_REG_VERIFY_LIB. |* No verification | --- Comment #50 from David Nind <david@davidnind.com> --- I've added a follow-up to update the PatronSelfRegistrationVerifyByEmail system preference description. It looked a little odd to have the options first without some sort of introduction, and the options starting in lowercase. I'm not sure that I got it totally right, but I think it is an improvement. Testing notes (using KTD): 1. The tests pass, but there are errors (these are the same before the patches, so not related to this bug): prove t/db_dependent/Koha/Patron/Modifications.t t/db_dependent/Koha/Patron/Modifications.t .. 1/8 DBIx::Class::Storage::DBI::insert(): Missing value for primary key column 'borrowernumber' on BorrowerModification - perhaps you forgot to set its 'is_auto_increment' attribute during add_columns()? Treating 'borrowernumber' implicitly as an autoinc, and attempting value retrieval at /kohadevbox/koha/Koha/Object.pm line 174 t/db_dependent/Koha/Patron/Modifications.t .. 5/8 DBIx::Class::Storage::DBI::insert(): Missing value for primary key column 'verification_token' on BorrowerModification - perhaps you forgot to set its 'is_auto_increment' attribute during add_columns()? Treating 'verification_token' implicitly as an autoinc, and attempting value retrieval at /kohadevbox/koha/Koha/Object.pm line 174 t/db_dependent/Koha/Patron/Modifications.t .. ok All tests successful. Files=1, Tests=8, 2 wallclock secs ( 0.01 usr 0.00 sys + 1.60 cusr 0.40 csys = 2.01 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.