https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #74 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 135865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135865&action=edit Bug 11889: (follow-up) Get rid of FIXME in Koha::Patron Instead of get_lists, I added ->virtualshelves. I removed the addition of the suffix to the shelf name here; if we really want that (doubts), we should do it pref based. Removing a staff member with public lists would result in weird names with shelf numbers on the OPAC. (Should be very easy to restore.) Used this opportunity to refactor the patron->delete subtest a bit: switching to build_object, removing the 'retrieved patrons', differentiating between staff patron and patron for sharing, adding a few tests. Test plan: Enable transfer ownership. Delete a patron with lists in interface. Check what happened. Run t/db_dependent/Koha/Patrons.t. -- You are receiving this mail because: You are watching all bug changes.