https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 --- Comment #8 from wainuiwitikapark@catalyst.net.nz --- (In reply to Owen Leonard from comment #6)
Some comments:
1. We don't need new CSS to hide the heading on the main page. We can add the Bootstrap class ".sr-only"
2. I don't think it's necessary to add headings inside <caption> and <legend>, e.g. opac-memberentry.tt:
- <legend id="mainaddress_legend">Main address</legend> + <legend id="mainaddress_legend"><h2>Main address</h2></legend>
Semantically speaking I think the legend is correct, and that the heading isn't necessary. Is there a particular accessibility tool behavior you're trying to address?
3. It is invalid to put a heading tag inside a <label> (e.g. opac-advsearch.tt). I have the same question as above about whether this change addresses some specific need.
4. I disagree that a heading shouldn't be used inside a message like this (opac-results.tt):
<div class="dialog alert"> - <h4>Error:</h4> + <p><strong>Error:</strong></p>
4. This patch adds an invalid file: .opac-readingrecord.tt.swo
Thanks so much for testing, will have a look into those things now. -- You are receiving this mail because: You are watching all bug changes.