http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master because this patch resolves the discrepancy, but I must confess to a number of reservations: - the same section of code sets and uses both $control_branchcode and $circControlBranch - the patch effectively adds copy-pasta rather than moving more of the fine-calculation code into a routine that could be shared by fines.pl and AddReturn() - the fact that the patch couldn't use _GetCircControlBranch and is overloading the PickupLibrary value for CircControl, while consistent with fines.pl, is IMO stretching the CircControl syspref a bit too far. - the patch include whitespace changes that obscured its purpose - this patch is crying out for DB-dependent test cases -- You are receiving this mail because: You are watching all bug changes.