https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #963 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Created attachment 206102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206102&action=edit Bug 10190: (QA follow-up): fixes phase six 1. add missing <tr> wrapper element 2. amend casing in cypress test 3. change method name so it is codespell-friendly 4. remove deprecated test from TestBuilder.t (used Overduerules which do not exist anymore. rely on 'Tests with composite FK in userpermission' for FK test coverage instead -> no replacement introduced.) 5. 'Bug 10190: Fix patron_categories permission format' changed the permission for GET requests to patron_categories to catalogue = 1, matching the Koha precedent for such endpoints. However, patron_categories still tested the endpoint with the old permission assigned. Amend this to complete the work started in that commit. 6. remove redundant delete statement in permission test: if the test fails, this means the db update has not run, and should. It would be incorrect for the db to still include the permission at the point where the test runs. Test plan: 1. run `npm run js:build` (or watch the js:watch output) 2. run t/cypress/integration/Admin/CirculationTriggers_spec.ts 3. run prove xt/author/codespell.t 4. run prove t/db_dependent/TestBuilder.t 5. run prove t/db_dependent/api/v1/patron_categories.t 6. run prove t/Koha/Auth/Permissions.t All should run with no warnings or errors. Assisted-by: Claude Opus 5 (Anthropic) Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.