http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #107 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32165&action=edit [PASSED QA] BUG8446, Follow up: Refactor to clean up bad practice - A number of issues were highlighted whilst writing sensible unit tests for this module. - Removed unnessesary call to context->new(); - Global variables are BAD! - Croaking is a wimps way out, we should handle errors early and properly. Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.