https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43962 Bug ID: 43962 Summary: Use the shared rounding engine in acquisitions with per-vendor rounding settings Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Depends on: 43957 Blocks: 23728 Target Milestone: --- Use the shared rounding engine in acquisitions and allow rounding to be set per vendor. Part of the currency rounding work collected on bug 23728. Acquisitions currently has its own implementation: C4::Acquisition::get_rounded_price and get_rounding_sql (CAST(x*100 AS SIGNED)/100) driven by OrderPriceRounding. Several screens ignore it (bugs 37937, 37938, 41708, 35114). Proposed: - Replace both functions with the shared engine and the OutgoingRounding preferences. - Add nullable rounding mode and timing columns to aqbookseller; when null, fall back to the system preferences. - Fix the screens that ignore the setting. Needs an atomicupdate and DBIC schema update. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23728 [Bug 23728] Rounding code should be moved to a Koha module so code can be centralised https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43957 [Bug 43957] Add per-currency decimal digits and configurable rounding policy preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.