https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98861|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99221&action=edit Bug 24494: tests: 00-valid-xml.t shouldn't check node_modules == Test plan == - work with SCSS (just recompile it if you never did) - https://wiki.koha-community.org/wiki/Working_with_staff_client_SCSS - now you have a node_modules directory - prove -r t/00-valid-xml.t - it should fail on files in node_modules - apply this patch - prove -r t/00-valid-xml.t - it should work - sabotage a legitimate XML file, like etc/SIPconfig.xml - prove -r t/00-valid-xml.t - it should fail, good the test is still useful - undo the sabotage Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.