https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43777 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thank you Jonathan and Adolfo for taking the time to look at this, it is genuinely appreciated, and Adolfo in particular for tracing the svc/bib leftover so precisely. A bit of context that might help for next time: this work was split into a tree of bugs at the request of QA folks (35104 -> 43777 -> 43025 -> its children) so that each piece could be reviewed in isolation. 43777 has been sitting in the queue asking for eyes for quite a while, so it is a little disheartening to receive the feedback after the push rather than when it was requested. For a change like this the whole tree really does need to be read together, as several of the concerns raised here (visibility of the repairs, removal of the old handling) are deliberately delivered by the dependent bugs. If anyone has concerns about the direction, the best moment to raise them is while the bugs are in Needs Signoff / Needs QA, and I will happily wait for them. That said, the points raised are fair, and some parts really were missing from the pushed work. Taking them in turn: 1. Feedback when data is repaired: delivered by bug 43025 (edit form) and bug 43026 (detail / MARC detail pages), both now pushed. Still to come: the advanced cataloguing editor (bug 43642) and TransformHtmlToMarc (bug 43776). 2. Removing the old handling: Adolfo is right that svc/bib was missed (record_strip_nonxml is called but no longer exists, and the invalid-metadata header is never sent for repaired records). Filed as bug 44069. 3. t/db_dependent/selenium/regressions.t: the test still expects the old biberror message for a record that is now repaired on read. Filed as bug 44070. 4. Number of reviewers: fair point, and I would be glad of more eyes on the rest of the tree. Both new bugs depend on 43025 and I am working on them now, together with the remaining open bugs in the tree that do not have patches yet (43021, 43022, 43023, 43024, 43642, 43776) and rebasing those that do (43020, 43028). I would really appreciate testing and sign-offs as they arrive. Thanks again! -- You are receiving this mail because: You are watching all bug changes.