https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 --- Comment #71 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- This looks really great Nick, thanks very much for looking at this. It looks like we were both rebasing the same bug at the same time! :-) To respond to your comments:
I don't know about the call to 'GetFine' in the renew_item sub, seems an extra DB hit. I am not sure either - how do you end up with more than one OVERDUE fine on an item?
It was a while ago, so I'm just speculating, but I suspect I did the call to GetFine and checked the fine to ensure that the fine had been fully paid off and no outstanding amount remained. Does that make sense? Anyway, your rebasing work looks great! Many thanks again for your work on this. -- You are receiving this mail because: You are watching all bug changes.