https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39532 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Script |Script |debar_patrons_with_fines.pl |debar_patrons_with_fines.pl |creates repeat |should use SUSPENSION |restrictions, uses wrong |restriction type |restriction type | Version|unspecified |Main Status|Passed QA |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Have to confess I am a bit worried about this interfering with any existing SUSPENSION restrictions that are set with specific expiration dates. See: _calculate_new_debar_dt As I see it running this scripts will just overwrite any existing SUSPENSION restriction with a date provided in the script when run. It feels to risky especially as a change in behavior that might not be noticed in time. I feel like we should not reuse the code here but make the code to use configurable. If we need to pick I think OVERDUES would be the better choice as this is just an indefinite one where the risk of interfering is lower. -- You are receiving this mail because: You are watching all bug changes.